Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking constructor arguments passed via Substitute.For/Substitute.ForPartsOf #1

Closed
dtchepak opened this issue May 22, 2018 · 2 comments
Closed

Checking constructor arguments passed via Substitute.For/Substitute.ForPartsOf #1

dtchepak opened this issue May 22, 2018 · 2 comments
Assignees
@tpodolak
Labels
enhancement New feature or request
Milestone
0.1.0-beta2

Comments

@dtchepak
Copy link
Member

Using an analyser for this came up in NSub#314, so I thought I'd raise this issue here for discussion and to see how practical it would be to implement.
@dtchepak dtchepak added the enhancement New feature or request label May 22, 2018
@dtchepak dtchepak mentioned this issue May 22, 2018
Open
@tpodolak
Copy link
Member

tpodolak commented May 24, 2018 •
edited
Loading

I took an initial look at this one, and as for today I think I know how to write analyzer which prevents you from using

  • ForPartsOf on delegates and interfaces
  • ForPartsOf/For without arguments if there is no parameters constructor
  • ForPartsOf/For with wrong arguments if there is only one constructor and you pass the parameters directly (not via new [] { arg1, arg2, arg3 }) - this one is tricky but probably possible

The real problem for me will be situation when your class has multiple constructors and then I have to figure out proper overload to choose based on arguments user provided. I didn't find any public API in Roslyn which would do that for me, so this particular feature might not be implemented.

tpodolak added a commit that referenced this issue May 27, 2018
@tpodolak
[GH-1] - first draf of substitute analyzers
1bc8396
tpodolak added a commit that referenced this issue May 27, 2018
@tpodolak
[GH-1] - Fixing stylecop issues
bff9bc1
tpodolak added a commit that referenced this issue May 27, 2018
@tpodolak
[GH-1] - Refactoring of substitute analyzers, first attempts to write…
a582a77 
… meaningful tests
tpodolak added a commit that referenced this issue May 27, 2018
@tpodolak
[GH-1] - Additional tests for c# implementation
789dc71
tpodolak added a commit that referenced this issue May 27, 2018
@tpodolak
[GH-1] - Attempting to analyze non generic version of Substitute.For
0c5aa94
tpodolak added a commit that referenced this issue Jun 1, 2018
@tpodolak
[GH-1] - changing project structure in preparation of CodeFixProviders
aaac82b
tpodolak added a commit that referenced this issue Jun 1, 2018
@tpodolak
[GH-1] - taking into account null values in substitute initializers
ff3d0dc
tpodolak added a commit that referenced this issue Jun 1, 2018
@tpodolak
[GH-1] - reducing amount of constructor types calculation to minimum
efb21a8
tpodolak added a commit that referenced this issue Jun 9, 2018
@tpodolak
[GH-1] - Adding test cases for Visual Basic - still problems with imp…
37edcaf 
…lict conversion and some test cases
tpodolak added a commit that referenced this issue Jun 9, 2018
@tpodolak
Merge branch 'GH-1-SubstituteForAnalyzers' of https://github.com/nsub…
85cd1c6 
…stitute/NSubstitute.Analyzers into GH-1-SubstituteForAnalyzers
tpodolak added a commit that referenced this issue Jun 9, 2018
@tpodolak
[GH-1] - first attempts to write code fix providers for wrong usage o…
55b7fd4 
…f For and ForPartsOf
tpodolak added a commit that referenced this issue Jun 9, 2018
@tpodolak
[GH-1] - handling well known conversions
536c401
tpodolak added a commit that referenced this issue Jun 10, 2018
@tpodolak
Merge branch 'dev' into GH-1-SubstituteForAnalyzers
4ce8f6d
tpodolak added a commit that referenced this issue Jun 10, 2018
@tpodolak
[GH-1] - adapting to the dev changes - first stage
f691234
tpodolak added a commit that referenced this issue Jun 10, 2018
@tpodolak
[GH-1] - adapting to the dev changes - second stage
ff9582a
tpodolak added a commit that referenced this issue Jun 10, 2018
@tpodolak
[GH-1] - first draft of SubstituteAnalyzer adjusted to dev branch cha…
dcbc78d 
…nges
tpodolak added a commit that referenced this issue Jun 10, 2018
@tpodolak
[GH-1] - adding code fix providers adjusted to dev branch changes
005a6df
tpodolak added a commit that referenced this issue Jun 10, 2018
@tpodolak
[GH-1] - fixing typos, adding convention tests for code fix providers
6ea7adc
tpodolak added a commit that referenced this issue Jun 13, 2018
@tpodolak
[GH-1] - fixing failing tests, better structure of SubstituteAnalyzer
d5e381e
tpodolak added a commit that referenced this issue Jun 13, 2018
@tpodolak
[GH-1] - adjusting namespaces, using async instead of blocking calls
2cbfa26
tpodolak added a commit that referenced this issue Jun 13, 2018
@tpodolak
[GH-1] - adding missing awaits
fddae9d
tpodolak added a commit that referenced this issue Jun 13, 2018
@tpodolak
[GH-1] - removing overloaping tests
7133335
tpodolak added a commit that referenced this issue Jun 13, 2018
@tpodolak
[GH-1] - Suppressing xUnit warnings on class level rather than globally
dedc3fe
tpodolak added a commit that referenced this issue Jun 14, 2018
@tpodolak
[GH-1] - using constants instead of magic strings in fix providers
554251c
tpodolak added a commit that referenced this issue Jun 14, 2018
@tpodolak
[GH-1] - Proper quick-fix name
10d7c48
tpodolak added a commit that referenced this issue Jun 16, 2018
@tpodolak
[GH-1] - ignoring constructor analysis when proxy is type argument
9806bd4
tpodolak added a commit that referenced this issue Jun 17, 2018
@tpodolak
[GH-1] - more descriptive messages for csharp implementation, initial…
1c3c766 
… fixes for VB
tpodolak added a commit that referenced this issue Jun 17, 2018
@tpodolak
[GH-1] - VB messages improved
c5e106c
@tpodolak tpodolak self-assigned this Jun 17, 2018
@dtchepak dtchepak mentioned this issue Jun 18, 2018
Merged
tpodolak pushed a commit that referenced this issue Jun 18, 2018
@dtchepak @tpodolak
Minor message tweaks (#14)
e1317b4 
[GH-1] - Minor message tweaks
tpodolak added a commit that referenced this issue Jun 18, 2018
@tpodolak
Merge pull request #13 from nsubstitute/GH-1-SubstituteForAnalyzers
980eee2 
[GH-1] - Checking constructor arguments passed via `Substitute.For`/`Substitute.ForPartsOf`
@tpodolak
Copy link
Member

Fixed in #13

@tpodolak tpodolak mentioned this issue Jul 28, 2018
Closed
@tpodolak tpodolak added this to the 0.1.0-beta2 milestone Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpodolak tpodolak

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0-beta2
Development

No branches or pull requests
2 participants
@dtchepak @tpodolak