Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NS1003 fix provider - simplify InternalVisibilityTo when System.Runtime.CompilerServices in scope #142

Closed
tpodolak opened this issue Mar 25, 2020 · 0 comments · Fixed by #143
Closed

NS1003 fix provider - simplify InternalVisibilityTo when System.Runtime.CompilerServices in scope #142

tpodolak opened this issue Mar 25, 2020 · 0 comments · Fixed by #143
Labels
enhancement New feature or request
Milestone
1.0.13

Comments

@tpodolak
Copy link
Member

Current implementation of InternalSetupSpecificationCodeFixProvider always introduces fully qualified
[assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2"")] attribute. Fix provider should be smart enough to simplify the type when required namespaces are imported already
@tpodolak tpodolak added the enhancement New feature or request label Mar 25, 2020
tpodolak added a commit that referenced this issue Mar 25, 2020
@tpodolak
[GH-142] - adding simplified InternalsVisibleTo("DynamicProxyGenAssem…
f56f602 
…bly2") when System.Runtime.CompilerServices in scope
tpodolak added a commit that referenced this issue Mar 25, 2020
@tpodolak
[GH-142] - adding simplified InternalsVisibleTo("DynamicProxyGenAssem…
e13d04a 
…bly2") when System.Runtime.CompilerServices in scope
@tpodolak tpodolak mentioned this issue Mar 25, 2020
Merged
tpodolak added a commit that referenced this issue Mar 26, 2020
@tpodolak
[GH-142] - adding simplified InternalsVisibleTo("DynamicProxyGenAssem…
7d37760 
…bly2") when System.Runtime.CompilerServices in scope
tpodolak added a commit that referenced this issue Mar 26, 2020
@tpodolak
[GH-142] - adding simplified InternalsVisibleTo("DynamicProxyGenAssem…
d18ec65 
…bly2") when System.Runtime.CompilerServices in scope
tpodolak added a commit that referenced this issue Mar 27, 2020
@tpodolak
[GH-142] - adding simplified InternalsVisibleTo("DynamicProxyGenAssem…
7ac8b34 
…bly2") when System.Runtime.CompilerServices in scope (#143)
@tpodolak tpodolak added this to the 1.0.13 milestone Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.13
1 participant
@tpodolak