Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify resource files #22

Closed
tpodolak opened this issue Jul 18, 2018 · 1 comment
Closed

Unify resource files #22

tpodolak opened this issue Jul 18, 2018 · 1 comment
Assignees
Labels
Non functional requirement Code quality related work
Milestone

Comments

@tpodolak
Copy link
Member

Currently, each analyzer library (C# or VB version) has its own Resources.resx file which contains messages for every diagnostic. As it was noted by @dtchepak
in #14 (comment) in most of the cases, the messages are the same and they only differ in some particular scenarios. Having that in mind we should find a way to share messages across analyzer libraries and override some of them when needed. Thanks to that approach we will avoid message duplication which will make the code-base cleaner and easier to maintain

@dtchepak
Copy link
Member

This is excellent 👍

@tpodolak tpodolak added this to the 0.1.0-beta2 milestone Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non functional requirement Code quality related work
Projects
None yet
Development

No branches or pull requests

2 participants