Incorrect NS4000 when using typeof expression

[samcragg]

I think the analyzer is incorrectly firing NS4000: Returns() is set with a method that itself calls Returns for the following code (this is the simplest I could get the code to reproduce the warning I was getting):

public interface IExample
{
    object Method();
}

public class ExampleTest
{
    [Fact]
    public void TypeofTestClass()
    {
        IExample example = Substitute.For<IExample>();
        example.Method().Returns(typeof(ExampleTest));
        //                       ^^^^^^^^^^^^^^^^^^^
    }
}

This is under dotnet-core 2.1 with using NSubstitute version 4.0.0, NSubstitute.Analyzers.CSharp version 1.0.5 and xunit version 2.4.1

Granted, the above code doesn't look realistic (there's no asserts!), however, I was getting the warning in one of my actual tests and it seems to be the typeof(TheClassContainingTheTest) that triggers it.

Let me know if there's anything I can do to help.

[tpodolak]

@samcragg thanks for reporting, this one for sure is a bug. Fix is waiting for review

[tpodolak]

@samcragg fix will be available in next release

[tpodolak]

@samcragg released in 1.0.6

[samcragg]

Just to confirm that's fixed it, thanks - that was an amazingly quick turnaround!