Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 11 allow configuration of safe api misuses #21

Merged
merged 21 commits into from
Jul 18, 2018
Merged

Gh 11 allow configuration of safe api misuses #21

merged 21 commits into from
Jul 18, 2018

Conversation

tpodolak
Copy link
Member

Closes #11
Things to be aware of:

  • TinyJson was incorporated into the source code as Newtonsoft.Json package was causing typeload exceptions once analyzer was deployed to Visual Studio
  • for easier debugging I've added vsix projects for VB and C# analyzers, there are not meant to be pushed to nuget or anywhere else, they are in here only for easier debugging of deployed package in VS
  • due to the bug in Roslyn (Solution.AddAdditionalDocument does not add a new file with AdditionalFiles item type dotnet/roslyn#4655) we are not able to add nsubstitute.json from analyzer directly - as it will not appear as additional analyzer file. Because of that bug user have to create empty file on its own in order for the suppressions to work
  • suppressions was only implemented for rule NS001 - non-virtual member call, as far as I know there is no other ways of safe api abuses

@tpodolak
[GH-11] - first draft of analyzers settings
8901991
@tpodolak
[GH-11] - tests for Returns method
9e0ac87
@tpodolak
[GH-11] - tests for generic members
9867eb1
@tpodolak
[GH-11] - rest of the tests for csharp implementation
0147203
@tpodolak
[GH-11] - Tests for Visual Basic implementation
17948a8
@tpodolak
[GH-11] - handling invalid configuration file
97ead42
@tpodolak
[GH-11] - attempting generate suppression file
e1c34f6
@tpodolak
[GH-11] - code fix provider for adding suppressions to nsubstitute.json
0888ddd
@tpodolak
[GH-11] - tests for DefaultSuppressDiagnosticsCodeFixProvider for non…
683944f 
…-virtual member diagnostics
@tpodolak
[GH-11] - adjusting vb solution tests structure
2f91701
@tpodolak
[GH-11] - temporarly removing vsix project from solution
6e9812c
@tpodolak
[GH-11] - tests for DefaultSuppressDiagnosticsCodeFixProvider for non…
27afb63 
…-virtual member diagnostics - vb version
@tpodolak
[GH-11] - NSubstitute.Analyzers.CSharp vsix project for easier debugging
c524d32
@tpodolak
[GH-11] - NSubstitute.Analyzers.VisualBasic vsix project for easier d…
eaa7d63 
…ebugging
@tpodolak
[GH-11] - Adding tests for namespace and class suppressions
3757f09
@tpodolak
[GH-11] - adding tests for code action titles
88458a6
@tpodolak
[GH-11] - extracting interfaces for testsing
6c7948e
@tpodolak
[GH-11] - fixing vsix build issues
1f58848
@tpodolak
[GH-11] - adding launch.json for vsix projects for easier debuggin in VS
17d297d
@tpodolak
Merge branch 'dev' of https://github.com/nsubstitute/NSubstitute.Anal…
b425f15 
…yzers into GH-11-allow-configuration-of-safe-api-misuses
@tpodolak
[GH-11] - Removing Newtonsoft.Json, supporting suppressions for exten…
4645b63 
…sion methods
@coveralls
Copy link

Pull Request Test Coverage Report for Build wcx46yssqfkdq6wj

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.3%) to 95.954%
Totals Coverage Status
Change from base Build yt8y3im84kbfrkjq: -1.3%
Covered Lines: 664
Relevant Lines: 692
💛 - Coveralls

dtchepak
dtchepak approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell! 😅

I'm trying to test this out. Do I add nsubstitute.json to solution items, or to the specific csproj?

@tpodolak
Copy link
Member Author

@dtchepak nsubstitute.json must be placed in given project plus it has to be marked as additional analyzer file (build action)

@dtchepak
Copy link
Member

@tpodolak Got it, thanks! 👍 Works great. That Roslyn bug is frustrating though!

@tpodolak tpodolak merged commit 1a911be into dev Jul 18, 2018
@dtchepak dtchepak mentioned this pull request Sep 18, 2018
Closed
@tpodolak tpodolak deleted the GH-11-allow-configuration-of-safe-api-misuses branch January 31, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtchepak dtchepak dtchepak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tpodolak @coveralls @dtchepak