Consider removing the Extensions.Zip() method or make it internal

[zvirja]

Issue is about the following API:

NSubstitute/src/NSubstitute/Core/Extensions.cs

Line 25 in 78410f8

public static IEnumerable<TResult> Zip<TFirst, TSecond, TResult>(

Currently .NET contains the Zip() API and you don't seem to target .NET 3.5 more. Therefore, consider removing this method from your API or at least make this extension method internal. Otherwise, it always pops-up in completion menu adding a confusion.

Likely, you will be able to do that only in the next major version, but for now you can obsolete it.

Thanks 😉

[dtchepak]

Thanks @zvirja. :)

I don't think we need to worry about obsoleting; the NSubstitute.Core namespace is for internal stuff only. The public API in NSubstitute parent namespace is the one we try to keep stable.

[zvirja]

Does your project follow the SemVer? If so, you are not permitted to remove methods within the same major. It could happen that somebody downstream used it (e.g. accidentally) and it will become broken after a minor update.. I accidentally noticed the namespace - that is very tricky assumption that somebody pays attention to the namespace the completion suggests 😉

I'd strongly recommend to follow the SemVer and do not violate it, otherwise it would be a hell to depend on this package 😕