Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument matching tests to demonstrate matching of value and reference types #671

Merged

Conversation

suzicurran
Copy link
Contributor

@suzicurran suzicurran commented Oct 22, 2021

Resolves #524.

Also: I think it would be good to also add tests for the Record types given their behavior, but don't believe this would be compatible with all the build targets since they're a newer feature. I didn't see an obvious way to manage this, but would be happy to come back in a subsequent PR if the test structure supports it.

@suzicurran suzicurran marked this pull request as ready for review October 22, 2021 19:22
@suzicurran suzicurran changed the title (Draft) Add argument matching tests to demonstrate matching of value and reference types Add argument matching tests to demonstrate matching of value and reference types Oct 22, 2021
Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! 🙇

@dtchepak dtchepak merged commit e15f0f4 into nsubstitute:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests to assert we match call arguments by reference
2 participants