Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using fixtures when searching via query params #34

Closed
johnmosesman opened this issue May 9, 2018 · 1 comment · Fixed by #35
Closed

Using fixtures when searching via query params #34

johnmosesman opened this issue May 9, 2018 · 1 comment · Fixed by #35
Labels
enhancement

Comments

@johnmosesman
Copy link

Is there support for using the fixture files when searching via query parameters? If so what is the file format name, or does it look inside the fixture data?

Ex: Shopify.session |> Shopify.Order.all(%{order_number: 1024, status: "any"})
@Ninigi Ninigi mentioned this issue May 10, 2018
Merged
@Ninigi
Copy link
Collaborator

Ninigi commented May 10, 2018

Hi there. The mock adapter does not have a query params support yet, however I just implemented a basic support in this pull request.

@Ninigi Ninigi closed this as completed in #35 Jul 4, 2018
Ninigi added a commit that referenced this issue Jul 4, 2018
@Ninigi
Basic support for query params in mock adapter
5c38f5e 
Closes #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Basic support for query params in mock adapter nsweeting/shopify
2 participants
@johnmosesman @Ninigi