Introduce Shopify.Error to handle response failures #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ninigi thanks for a quick feedback on #37
I think we should keep returning shopify errors wrapped in
Shopify.Response
, because it is response.And for failed requests we pass errors from
HTTPoison
. ActuallyHTTPoison
does the same, passing errors fromhackney
. So with the solution I propose in this PR we get ability to handle these errors coming from the deep.If we don't use
Shopify.Error
for API errors we don't really need to make it backward compatible.I tested this solution on my real app that exports thousands of records, by switching network on and off to produce network errors, and it worked well.