Added ScriptTag and fixed Shopify.OAuth request #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arams than resources
|
@overallduka - thanks for your work. I'll try and get things merged up today. |
nsweeting
reviewed
Feb 8, 2017
| @@ -51,7 +51,7 @@ defmodule Shopify.Mixfile do | |||
| # Type "mix help deps" for more examples and options | |||
| defp deps do | |||
| [ | |||
| {:httpoison, "~> 0.10.0"}, | |||
| {:httpoison, "~> 0.8.0"}, | |||
There was a problem hiding this comment.
Is the version drop required for the SSL changes?
There was a problem hiding this comment.
Oh, i don't think so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the ScriptTag resource, fix the issues #3 #4 #5 and add what needed for retrieve access token works fine.