Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix font memory leak. #57

Merged
merged 2 commits into from Sep 16, 2021
Merged

Fix font memory leak. #57

merged 2 commits into from Sep 16, 2021

Conversation

Ytrewq13
Copy link
Contributor

This memory leak has always been present in sxiv.

The font opened on window.c:58 was never closed, so I closed it, fixing a 2kB memory leak (2497 bytes).

@N-R-K N-R-K changed the base branch from master to dev September 16, 2021 16:09
eylles
eylles approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@eylles eylles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a very small fix and if others can confirm it breaks nothing (the bar still works for me) then we should merge it.

@XPhyro XPhyro changed the base branch from dev to master September 16, 2021 20:15
Ytrewq13 and others added 2 commits September 17, 2021 02:19
@Ytrewq13 @N-R-K
Fix font memory leak.
f64a7c3 
This memory leak has always been present in sxiv.

The font opened on window.c:58 was never closed, so I closed it, fixing a 2kB memory leak.
@N-R-K
document changes
e521840
@N-R-K N-R-K merged commit 0d8dcfd into nsxiv:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XPhyro XPhyro XPhyro approved these changes

@eylles eylles eylles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Ytrewq13 @XPhyro @eylles @N-R-K