forked from WebKit/WebKit
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[view-transitions] Names should be tree-scoped
https://bugs.webkit.org/show_bug.cgi?id=273883 rdar://127995859 Reviewed by Antti Koivisto. Corresponding spec issue: w3c/csswg-drafts#10145 Corresponding spec PR: w3c/csswg-drafts#10306 This ignores view-transition names from shadow DOM, given the pseudo-elements are linked to the document element, exposing shadow DOM names to the view transition pseudo-elements would be a violation of shadow DOM principles. We don't check for the tree scope directly in `forEachRendererInPaintOrder` because a shadow DOM element might have flat tree descendants that have an outer tree scope. We also use the `Styleable`'s element instead of `RenderElement`'s element because for pseudo-elements we want to consider the associated element's tree scope. * LayoutTests/TestExpectations: * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::captureOldState): (WebCore::ViewTransition::captureNewState): Canonical link: https://commits.webkit.org/278704@main
- Loading branch information
Showing
3 changed files
with
5 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters