-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger implementation should log non-error messages as breadcrumbs. #41
Comments
Will add this to the backlog thanks |
Would you accept a PR? I've already forked and implemented it. |
Thanks.. I'll review it @empz |
This feature as been added in the latest version 3.0.7 |
I see you've added a parameter to Somewhere in the forRoot config we should have the option to say "store non-error messages as breadcrumbs". |
@dg-eparizzi Created a PR here, but I did it in the forked version from |
The default behaviour of any Sentry SDK is to capture non-error logs as breadcrumbs and send them all together as soon as an error happens.
I see
SentryService
extendsLogger
but the methods log, debug, verbose and warn are actually callingcaptureMessage
and I think they should be storing that log as a breadcrumb in the current scope.This way, replacing the default NestJS logger with this library would be a no-brainer and we'd get proper log messages before an exception on Sentry.
The text was updated successfully, but these errors were encountered: