Bump uuid and only require uuid/v4 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgbkrk
reviewed
Nov 29, 2016
| const path = require('path'); | ||
|
|
||
| const chalk = require('chalk'); | ||
| const identity = uuid.v4(); | ||
| const identity = uuid(); |
There was a problem hiding this comment.
The only thing I'm not too pleased with in this PR is the inconsistency of using uuid() vs. v4(). I'm leaning towards const uuidv4 = require('uuid/v4');
There was a problem hiding this comment.
How would you do this with ES6 imports?
Right now import v4 from 'uuid/v4'; works or should I use require?
There was a problem hiding this comment.
When it's the default import you can use
import uuidv4 from 'uuid/v4';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the version consistent with
jmpand help with webpack in the future.