New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Don't clear bubbles when reconnecting to dead remote kernel #1354
Comments
I don't know all of the details off hand as I dont use remote kernels much. Feel free to look into or send a PR if you think it's worth while |
That command has been removed and is no longer being maintained |
@wadethestealth This issue doesn't only talking about the When the remote kernel is really destroyed, it would better to clear all results as when a local kernel is shutdown, but if it's actually alive and we can reconnect to it, the results are better not to be cleared like when a local kernel is restarted. |
Shouldn't we just remove line 624 in lib/main then. @aviatesk |
Maybe ? But I'm not too sure about remote kernels and what the exact use case of this enhancement idea, thus I want to stay this open until @kylebarron returns us updates. |
Closed in favor of #635 |
This is somewhat similar to #1332, which discusses clearing bubbles when restarting a local kernel.
@nikitakit detailed how this behavior is helpful:
I'd like to propose that this same behavior is implemented for remote kernels. I work with remote kernels that become disconnected when my VPN times out. By using tmux on the server, I can connect to the same jupyter kernel after logging into the VPN again, but when I connect through Hydrogen again, Hydrogen clears all results.
I'm assuming that Hydrogen stores some information about the currently connected kernel, and that it would be possible for Hydrogen to know when the reconnected kernel is the same as the disconnected/dead one.
The decision to clear results might be different when starting a new remote kernel.
The text was updated successfully, but these errors were encountered: