Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Don't clear bubbles when reconnecting to dead remote kernel #1354

Closed
kylebarron opened this issue Jul 15, 2018 · 6 comments
Closed

ENH: Don't clear bubbles when reconnecting to dead remote kernel #1354

kylebarron opened this issue Jul 15, 2018 · 6 comments
Labels
duplicate Duplicates

Comments

@kylebarron
Copy link
Contributor

This is somewhat similar to #1332, which discusses clearing bubbles when restarting a local kernel.
@nikitakit detailed how this behavior is helpful:

Personally, the fact that bubbles aren't cleared has been a huge improvement for me. About a year ago hydrogen would always delete all bubbles when a kernel was restarted, which caused me to lose important experimental results more times than I can count. This behavior was changed in part to support #861 (the "Restart and Re Evaluate Bubbles" command).

I'd like to propose that this same behavior is implemented for remote kernels. I work with remote kernels that become disconnected when my VPN times out. By using tmux on the server, I can connect to the same jupyter kernel after logging into the VPN again, but when I connect through Hydrogen again, Hydrogen clears all results.

I'm assuming that Hydrogen stores some information about the currently connected kernel, and that it would be possible for Hydrogen to know when the reconnected kernel is the same as the disconnected/dead one.

The decision to clear results might be different when starting a new remote kernel.

@BenRussert
Copy link
Member

I don't know all of the details off hand as I dont use remote kernels much. Feel free to look into or send a PR if you think it's worth while

@wadethestealth wadethestealth added enhancement 🌟 New feature ideas good first issue Good for new contributors help wanted Help is desired labels Jun 4, 2019
@wadethestealth wadethestealth removed enhancement 🌟 New feature ideas good first issue Good for new contributors help wanted Help is desired labels Jul 3, 2019
@wadethestealth
Copy link
Member

That command has been removed and is no longer being maintained

@aviatesk
Copy link
Member

aviatesk commented Jul 3, 2019

@wadethestealth This issue doesn't only talking about the Hydrogen: Restart and Re Evaluate Bubbles command but rather "not clearing bubbles when a connection to a remote kernel is destroyed".

When the remote kernel is really destroyed, it would better to clear all results as when a local kernel is shutdown, but if it's actually alive and we can reconnect to it, the results are better not to be cleared like when a local kernel is restarted.

@aviatesk aviatesk reopened this Jul 3, 2019
@wadethestealth
Copy link
Member

wadethestealth commented Jul 3, 2019

Shouldn't we just remove line 624 in lib/main then. @aviatesk

@aviatesk
Copy link
Member

aviatesk commented Jul 3, 2019

Maybe ? But I'm not too sure about remote kernels and what the exact use case of this enhancement idea, thus I want to stay this open until @kylebarron returns us updates.

@wadethestealth wadethestealth added awaiting update Waiting for response/new news refactor labels Jul 3, 2019
@wadethestealth
Copy link
Member

Closed in favor of #635

@wadethestealth wadethestealth added duplicate Duplicates and removed awaiting update Waiting for response/new news refactor labels Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Duplicates
Projects
None yet
Development

No branches or pull requests

4 participants