Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make layout determined by actual size of the bubble and wrap lines #26

Closed
willwhitney opened this issue May 24, 2015 · 4 comments
Closed

Comments

@willwhitney
Copy link
Collaborator

This is to better accommodate kernels like IRkernel which output rich text (e.g. HTML) for even small results.

Bubbles which only contain text (regardless of formatting) should have a multiline-result style bubble (pictured below) if they're larger than a single line, and should fit inline with no close button if they're small.

HTML results should also have the same close/new pane buttons as text ones if they only contain text.

@willwhitney willwhitney added this to the v0.4.0 milestone May 24, 2015
@willwhitney willwhitney modified the milestones: v0.5.0, v0.4.0 Jun 15, 2015
@willwhitney willwhitney removed this from the next release milestone Dec 14, 2015
@n-riesco
Copy link
Collaborator

@lgeiger Is this issue something you'd like to have a go?

@lgeiger
Copy link
Member

lgeiger commented Mar 28, 2016

HTML results should also have the same close/new pane buttons as text ones if they only contain text.

I can give it a shot.

Bubbles which only contain text (regardless of formatting) should have a multiline-result style bubble (pictured below) if they're larger than a single line, and should fit inline with no close button if they're small.

This is the current behavior, isn't it?

@n-riesco
Copy link
Collaborator

Yes, it's the current behaviour.

I think the only thing that it's left to close this issue is to add the "copy to clipboard" and the "open in new pane" buttons in HTML result bubbles.

@lgeiger
Copy link
Member

lgeiger commented Mar 28, 2016

I'll soon make a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants