-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SyntaxError when creating multi-line dictionaries #724
Comments
We rely on Atom's Unfortunately this needs to be fixed in the |
Interesting. I'll open an issue at Thank you @lgeiger. |
I'm a MagicPython developer. Could you be more specific in whether there's a particular scope that's missing or something like that, please? |
I can reproduce this in an otherwise empty file, so I guess it's in the global scope. |
@lgeiger could you please give a little more detail on what information Hydrogen is relying on when determining code block boundaries? Is there some specific name that is given to the code block by the language parser that should be there? |
@lgeiger considering that Atom seems to have an known issue with code folding (e.g. atom/first-mate#48 and atom/atom#1183) would it be viable for Hydrogen to try and check for some special syntax scope (e.g. |
@vpetrovykh That's a good idea! We're very happy to accept a PR for this. |
There's actually a setting named |
Description:
A SyntaxError (unexpected OEF while parsing) is generated when creating a dictionary with a line break after the opening brace:
![syntaxerror](https://cloud.githubusercontent.com/assets/11261876/25156784/1cf75b16-24e0-11e7-8f70-e53d6c5656bb.png)
The syntax is valid, but Hydrogen will only execute the code properly if all the lines are selected first:
![noerror](https://cloud.githubusercontent.com/assets/11261876/25156760/eefe511a-24df-11e7-9694-5690696a4fcd.png)
Steps to Reproduce:
Hydrogen:run
.Versions:
Atom : 1.16.0
Electron: 1.3.13
Chrome : 52.0.2743.82
Node : 6.5.0
The text was updated successfully, but these errors were encountered: