fix(zoomReset): changed reset level to 0 #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.40% (diff: 100%)@@ master #1138 diff @@
==========================================
Files 57 57
Lines 1453 1453
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1299 1299
Misses 154 154
Partials 0 0
|
|
Awesome, thanks @alexandercbooth! |
|
My pleasure! |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when reseting zoom level to actual (CMD-0) that it wasn't the right size. It's my mistake, when I added this originally, I thought zoom level of 1 was 100%, but I see now it's actually zoom level 1. So I changed the actual reset level 0 to match the default and the corresponding test.