-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cell): Move cell status indicators to metadata key #1159
Conversation
Current coverage is 89.21% (diff: 100%)@@ master #1159 diff @@
==========================================
Files 57 57
Lines 1455 1456 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1298 1299 +1
Misses 157 157
Partials 0 0
|
value | ||
.deleteIn(['metadata', 'inputHidden']) | ||
.deleteIn(['metadata', 'outputHidden']) | ||
.delete(['metadata', 'status'])))), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While not a big deal, we could switch these to remove
(it's an alias in ImmutableJS).
Thank you for tackling this one and cleaning it all up! |
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Closes #1148.