(style) styles scrollbars according to theme #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This address issue #771 and adds flat style scroll bar to light, dark, classic, and nteract themes.
Current coverage is 89.05% (diff: 100%)@@ master #1184 diff @@
==========================================
Files 57 57
Lines 1444 1444
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1286 1286
Misses 158 158
Partials 0 0
|
|
This is looking excellent to me, certainly an improvement. Thank you. We can keep refining after so feel free to take the WIP out of the title here if it's ready to go! |
rgbkrk
approved these changes
Nov 14, 2016
jkornblum
changed the title
|
Sure thing. PR ready to be merged. Thanks. |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address issue #771 and adds a custom style scroll bar to the light, dark, classic, and nteract themes.
I know this is a style and subjective so I'm open to any suggestions for changes. If no suggestions this should be an upgrade from the default chrome style scroll bars throughout the application.
It is a flat style, which shows a small track using css box-shadow. The scroll bar color is a translucent version of the --main-fg-color (for dark themes) or --cm-background (for light themes). The scrollbar styling only applies inside the Electron window, i.e. the "main" window itself keeps the default platform style.
Here is a preview
