Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown): Fixed bug with pressing shift+enter in markdown cells in view mode #1194

Merged
merged 1 commit into from
Nov 15, 2016
Merged

fix(markdown): Fixed bug with pressing shift+enter in markdown cells in view mode #1194

merged 1 commit into from
Nov 15, 2016

Conversation

peggyrayzis
Copy link
Member

Bug squashed! 🐛 Now you should be able to shift+enter through a notebook with ease, no matter what type of cells it contains!

To test:

  • Open up the Pandas/GeoJSON example & shift+enter through the notebook. The cells should focus properly (highlight MD cells in view mode, focus editor on code cells)
  • You can also create a new notebook with MD cell (view mode) - code cell - MD cell (view mode) - code cell - MD cell (view mode). You should also be able to shift+enter through this notebook properly despite what type of cell you start at

Sorry these notes were not super coherent, see you at PLOTCON!! @rgbkrk

@codecov-io
Copy link

Current coverage is 88.52% (diff: 100%)

Merging #1194 into master will decrease coverage by <.01%

@@             master      #1194   diff @@
==========================================
  Files            57         57          
  Lines          1474       1473     -1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1305       1304     -1   
  Misses          169        169          
  Partials          0          0          

Powered by Codecov. Last update 4f95fb7...959da27

@jdetle jdetle merged commit ea185d2 into nteract:master Nov 15, 2016
@jdetle
Copy link
Member

jdetle commented Nov 15, 2016

💣 .com

@rgbkrk
Copy link
Member

rgbkrk commented Nov 15, 2016

Woo!

@lock
Copy link

lock bot commented Apr 3, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Apr 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants