feat(menu) add run cells below functionality #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Menu > Run Cells Below to menu and adds run cells below functionality. Enhances ./test/utils.js to add more configuration for building dummy notesbooks for test
Current coverage is 90.07% (diff: 100%)@@ master #1195 diff @@
==========================================
Files 57 57
Lines 1511 1521 +10
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1360 1370 +10
Misses 151 151
Partials 0 0
|
rgbkrk
approved these changes
Nov 15, 2016
| @@ -172,6 +172,31 @@ export function dispatchPublishUserGist(store, event, githubToken) { | |||
| store.dispatch({ type: 'PUBLISH_USER_GIST' }); | |||
| } | |||
|
|
|||
| /** | |||
| * Redux dispatch function to run the focused cell and all cells below it. | |||
| * It obtains the focused cell cell id and all code cell cell ids below. | |||
| const cellsBelowFocusedId = notebook.get('cellOrder').skip(indexOfFocusedCell); | ||
| const cells = notebook.get('cellMap'); | ||
|
|
||
| cellsBelowFocusedId.filter((cellID) => |
There was a problem hiding this comment.
Comment I'd love to see here if the check for code isn't on the same line for the filter:
// Only run on code cells
|
Went ahead and merged, feel free to make another PR with the suggestions I made if you like. |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Menu > Run Cells Below to the menu.
This functionality runs the currently focused cell and all cells below it.
I use this functionality quite frequently in Jupyter notebooks and have added it to nteract now.
Commit also Enhances ./test/utils.js to add more configuration for building dummy notebooks for test
All comments welcome, thanks!