Fix modified indicator #1204
Merged
Fix modified indicator #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgeiger
commented
Nov 17, 2016
| @@ -36,7 +36,7 @@ export function createTitleFeed(state$) { | |||
| const modified$ = state$ | |||
| .map(state => state.document.get('notebook')) | |||
| .scan((prev, notebook) => ({ | |||
| modified: prev.notebook === notebook, | |||
| modified: prev.notebook !== notebook, | |||
There was a problem hiding this comment.
Immutable.is(prev.notebook, notebook) === falsewill behave the same.
rgbkrk
force-pushed
the
fix-modified-indicator
branch
from
0e7e20d
to
313cf11
Compare
|
I just realized... We're missing logic for saved. All we know is if it was modified from last time. The logic should be modified: saved.notebook !== current.notebookYet we don't have |
Current coverage is 91.57% (diff: 100%)@@ master #1204 diff @@
==========================================
Files 57 57
Lines 1530 1531 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1401 1402 +1
Misses 129 129
Partials 0 0
|
|
Is this still WIP? |
|
It fixes a bug yet doesn't fix the modified feature. It can be merged, we've just got some work ahead of us. I think I know what to do for a follow up PR. |
|
Merging, thank you! |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses part of #1165
But it still fails in a interesting way:
