Conformance #1224
Merged
Conformance #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.57% (diff: 100%)@@ master #1224 diff @@
==========================================
Files 57 57
Lines 1531 1531
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1402 1402
Misses 129 129
Partials 0 0
|
|
I went ahead and opened all the notebooks we had after making sure they conformed first - the only that I'm seeing here that persist that shouldn't now is |
|
Nice! |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1168.
This will currently fail since several of our notebooks are invalid currently. I'm going to get them cleaned up as well.