Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix classic theme #1416

Merged
merged 2 commits into from Feb 7, 2017
Merged

Fix classic theme #1416

merged 2 commits into from Feb 7, 2017

Conversation

lgeiger
Copy link
Member

@lgeiger lgeiger commented Feb 7, 2017

Fix #1412
bildschirmfoto 2017-02-07 um 01 03 11

to allow themes to override CSS variables
and bring prompt-width closer to jupyter notebook
@rgbkrk
Copy link
Member

rgbkrk commented Feb 7, 2017

😂

@@ -57,11 +57,11 @@ class App extends React.PureComponent {
return (
<Provider store={store}>
<div>
<link rel="stylesheet" href="../static/styles/main.css" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been meaning to move the main.css stylesheet up for a very long time. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #1416 into master will not impact coverage.

@@           Coverage Diff           @@
##           master    #1416   +/-   ##
=======================================
  Coverage   90.44%   90.44%           
=======================================
  Files          66       66           
  Lines        1716     1716           
=======================================
  Hits         1552     1552           
  Misses        164      164

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f49aee...08a77da. Read the comment docs.

@rgbkrk rgbkrk merged commit bea8965 into nteract:master Feb 7, 2017
@lgeiger lgeiger deleted the fix-classic-theme branch February 7, 2017 00:09
@lock
Copy link

lock bot commented Apr 3, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Apr 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants