Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transform-dataresource #1657

Merged
merged 5 commits into from Apr 19, 2017
Merged

Conversation

gnestor
Copy link
Contributor

@gnestor gnestor commented Apr 19, 2017

  • Add required devDependencies
  • Upgrade react-virtualized
  • Update width, height, and column width logic
  • Update style
  • Accept constants as props

@gnestor gnestor mentioned this pull request Apr 19, 2017
@rgbkrk
Copy link
Member

rgbkrk commented Apr 19, 2017

Woo!

@rgbkrk
Copy link
Member

rgbkrk commented Apr 19, 2017

There are a few flow issues:

packages/transform-dataresource/lib/index.js.flow:23
 23:       <VirtualizedGrid
           ^ React element `VirtualizedGrid`
 61:   props: Props;
              ^^^^^ property `height`. Property not found in. See: packages/transform-dataresource/lib/virtualized-grid.js.flow:61
 23:       <VirtualizedGrid
           ^ props of React element `VirtualizedGrid`
packages/transform-dataresource/lib/index.js.flow:23
 23:       <VirtualizedGrid
           ^ React element `VirtualizedGrid`
 61:   props: Props;
              ^^^^^ property `width`. Property not found in. See: packages/transform-dataresource/lib/virtualized-grid.js.flow:61
 23:       <VirtualizedGrid
           ^ props of React element `VirtualizedGrid`
packages/transform-dataresource/src/index.js:23
 23:       <VirtualizedGrid
           ^ React element `VirtualizedGrid`
 61:   props: Props;
              ^^^^^ property `height`. Property not found in. See: packages/transform-dataresource/src/virtualized-grid.js:61
 23:       <VirtualizedGrid
packages/transform-dataresource/src/index.js:23
 23:       <VirtualizedGrid
           ^ React element `VirtualizedGrid`
 61:   props: Props;
              ^^^^^ property `width`. Property not found in. See: packages/transform-dataresource/src/virtualized-grid.js:61
 23:       <VirtualizedGrid
           ^ props of React element `VirtualizedGrid`

Looking really fantastic otherwise!

@codecov-io
Copy link

codecov-io commented Apr 19, 2017

Codecov Report

Merging #1657 into master will decrease coverage by 0.35%.
The diff coverage is 29.26%.

@@            Coverage Diff             @@
##           master    #1657      +/-   ##
==========================================
- Coverage   79.48%   79.12%   -0.36%     
==========================================
  Files          61       61              
  Lines        1994     1998       +4     
==========================================
- Hits         1585     1581       -4     
- Misses        409      417       +8

@rgbkrk
Copy link
Member

rgbkrk commented Apr 19, 2017

I'm going to go ahead and bring this in since flow is passing, even though the coverage dropped a little bit.

@rgbkrk rgbkrk merged commit f5b58f4 into nteract:master Apr 19, 2017
@rgbkrk
Copy link
Member

rgbkrk commented Apr 19, 2017

Looks like there is some lerna dependency synchronization I should do before publishing:

The repository root depends on jest@^19.0.0, which differs from the more common jest@^19.0.2.
"@nteract/transform-dataresource" package depends on jest@^19.0.2, which differs from the hoisted jest@^19.0.0.
The repository root depends on rimraf@^2.5.2, which differs from the more common rimraf@^2.6.1.
"@nteract/transform-dataresource" package depends on rimraf@^2.6.1, which differs from the hoisted rimraf@^2.5.2.
"@nteract/notebook-preview-demo" package depends on react-virtualized@^9.2.1, which differs from the hoisted react-virtualized@^9.7.3.

@lock
Copy link

lock bot commented Apr 2, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Apr 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants