New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update transform-dataresource #1657
Conversation
gnestor
commented
Apr 19, 2017
- Add required devDependencies
- Upgrade react-virtualized
- Update width, height, and column width logic
- Update style
- Accept constants as props
Woo! |
There are a few flow issues:
Looking really fantastic otherwise! |
4b39a89
to
069c9da
Compare
Codecov Report
@@ Coverage Diff @@
## master #1657 +/- ##
==========================================
- Coverage 79.48% 79.12% -0.36%
==========================================
Files 61 61
Lines 1994 1998 +4
==========================================
- Hits 1585 1581 -4
- Misses 409 417 +8 |
I'm going to go ahead and bring this in since flow is passing, even though the coverage dropped a little bit. |
Looks like there is some lerna dependency synchronization I should do before publishing:
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |