feat(notebook): add one-dark theme colors #1756
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1756 +/- ##
=======================================
Coverage 78.43% 78.43%
=======================================
Files 62 62
Lines 2091 2091
=======================================
Hits 1640 1640
Misses 451 451 |
| body | ||
| { | ||
| line-height: 1.3 !important; | ||
| } |
There was a problem hiding this comment.
@rgbkrk Uhm..The other themes had this property set, so I just let it stay here too.
There was a problem hiding this comment.
Oh hmmmm, perhaps we need that in main.css then?
There was a problem hiding this comment.
@rgbkrk That's right, I should have done that. Guess I should learn to step back and look at the big picture, instead of focusing narrowly on the specific problem I was trying to solve :-(
The line-height and the webkit scrollbar style properties are in all themes except the halloween, christmas and the "undefined" theme, which are not even exposed through the UI right now. I will move them into main.css very soon.
What is this undefined theme, anyway?
There was a problem hiding this comment.
Those are all easter eggs. 😄
There was a problem hiding this comment.
:-) Easter eggs should be exposed to the end-user somehow, no? These themes are exposed to the developer but...
There was a problem hiding this comment.
The Christmas and Halloween ones only come up during certain times of the year (and it would be ok if we had more). undefined has only one way of coming up, though you can enable it using the ~/.jupyter/nteract.json file. 😉
There was a problem hiding this comment.
"during certain times of the year " -> Gonna hunt for this part of the code.
" it would be ok if we had more" -> I'll add an Indian holiday soon if I can come up with the colors 😃
There was a problem hiding this comment.
I'll add an Indian holiday soon if I can come up with the colors
That's awesome!
By the way, I'm trying out packaging of the app again to prep for another release.
There was a problem hiding this comment.
I'll add an Indian holiday soon if I can come up with the colors
@Madhu94 that would be awesome!
By the way, I'm trying out packaging of the app again to prep for another release.
@rgbkrk I messed around with nteract some over the weekend. I wasnt able to build the deb file on ubuntu, but figured it was something I needed on my system. (I can get dev mode to work fine)
|
Thanks for doing this! |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
No description provided.