only run updateAndNotify on windows + macOS

[rgbkrk]

Fixing up

https://twitter.com/chendaniely/status/915402770655608834

[codecov-io]

Codecov Report

Merging #1931 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1931   +/-   ##
=======================================
  Coverage   80.01%   80.01%           
=======================================
  Files         116      116           
  Lines        4833     4833           
=======================================
  Hits         3867     3867           
  Misses        966      966

[chendaniely]

I've confirmed that this PR fixes the issue and runs on my arch machine (:

[rgbkrk]

Alright, I'll get this shipped then. It will be the first version that the macOS and Windows versions get an auto-update for amusingly. 😉

[chendaniely]

does it support marquees?

[rgbkrk]

Full blown enterprise level <marquee> support coming your way soon!

[rgbkrk]

(build running...)

[lgeiger]

I don't know why this is necessary. updateAndNotify should just be a noop on linux.

I'm wondering if it's because it's build on mac instead of on Linux.

[rgbkrk]

I'm wondering if it's because it's build on mac instead of on Linux.

Yeah that could be. I would hope webpack doesn't take a selective path while building the JS with an electron target.

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.