Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle codemirror css into editor package directly #2090

Merged
merged 1 commit into from Nov 23, 2017

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Nov 22, 2017

This brings the CodeMirror CSS inline to make it simpler to use the component.

@codecov
Copy link

codecov bot commented Nov 22, 2017

Codecov Report

Merging #2090 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2090      +/-   ##
==========================================
- Coverage   64.16%   64.11%   -0.05%     
==========================================
  Files          78       78              
  Lines        2372     2369       -3     
  Branches      333      264      -69     
==========================================
- Hits         1522     1519       -3     
- Misses        727      751      +24     
+ Partials      123       99      -24

@rgbkrk rgbkrk merged commit 2fcc1e3 into nteract:master Nov 23, 2017
@rgbkrk rgbkrk deleted the vendor-codemirror branch November 23, 2017 21:58
@lock
Copy link

lock bot commented Apr 2, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Apr 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant