New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Core State #2511
Create Core State #2511
Conversation
@rgbkrk any objections? |
@@ -174,6 +166,7 @@ type state = { | |||
[ref: Ref]: { | |||
name: string, | |||
resources: Object, | |||
hostRef: Ref, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you meant to stick the hostRef
in the kernels
byRef
as well.
@@ -189,8 +182,7 @@ type state = { | |||
[ref: Ref]: { | |||
id: string, | |||
type: ("local" | "jupyter"), | |||
selectedKernelRef: Ref, | |||
kernelRefs: Array<Ref>, | |||
kernelIds: Array<Id>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Howdy! I'm 🔓🤖! In order to keep information timely (based on the most recent release), we want all activity to be added to either new issues or open issues and PRs. In service to that goal, I, the lock bot close inactive closed issues when they haven't had activity in 120 days. Feel free to open a new issue for related bugs and link to relevant comments from this thread. |
[WIP: just wanted to push changes to plan.md up here]
Here's the types I ultimately want to end up with:
Then, I want to create a new reducer in
/core
that we export ascore
and that must be mounted at the top level of the state tree atcore
(maybenteract
as a namespace?) to work.I want to get this
state.core
hunk mirroring the information that's currently instate.app
,state.document
, etc, etc and then start switching selectors over to the new sub-tree one-by-one.This is mostly just documenting my own thoughts, but feel free to comment.