Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create unhide all redux setup #2517

Merged
merged 2 commits into from Feb 10, 2018
Merged

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Feb 10, 2018

This sets up a menu item that unhides both input and outputs for all cells in the document.

return cell.mergeIn(["metadata"], {
// TODO: Verify that we convert to one namespace for hidden input/output
outputHidden: !action.payload.outputs,
inputHidden: !action.payload.input
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me wonder if I should change the nomenclature and pattern to action.payload.outputHidden.

@rgbkrk rgbkrk added this to the Jupyter Extension M1 milestone Feb 10, 2018
@rgbkrk rgbkrk merged commit 9c80416 into nteract:master Feb 10, 2018
@rgbkrk rgbkrk deleted the unhide-all-action branch February 10, 2018 17:52
@rgbkrk rgbkrk mentioned this pull request Mar 7, 2018
7 tasks
@lock
Copy link

lock bot commented May 1, 2018

Howdy! I'm 🔓🤖!

In order to keep information timely (based on the most recent release), we want all activity to be added to either new issues or open issues and PRs. In service to that goal, I, the lock bot close inactive closed issues when they haven't had activity in 120 days.

Feel free to open a new issue for related bugs and link to relevant comments from this thread.

@lock lock bot locked and limited conversation to collaborators May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant