Refact more imports #2581
Refact more imports #2581
Conversation
theengineear
force-pushed
the
refact-more-imports
branch
from
bf47999
to
d65a0de
Compare
| @@ -296,19 +296,22 @@ export function watchSpawn(action$: *, store: *) { | |||
| return action$.pipe( | |||
| ofType(actionTypes.LAUNCH_KERNEL_SUCCESSFUL), | |||
| switchMap((action: NewKernelAction) => { | |||
| // $FlowFixMe | |||
| const spawn = action.kernel.spawn; | |||
There was a problem hiding this comment.
These make sense since our kernel is nullable. It's only too bad that the rx types don't pass on through because then we could do a filter that ensured there was a kernel and that it was a zeromq / local type.
I'll stick in some workarounds here at least.
There was a problem hiding this comment.
Ha, yah, I tried to filter it above to no avail :(.
|
Running this locally:
|
|
Looking great! Thanks! |
|
Howdy! I'm 🔓🤖! In order to keep information timely (based on the most recent release), we want all activity to be added to either new issues or open issues and PRs. In service to that goal, I, the lock bot close inactive closed issues when they haven't had activity in 120 days. Feel free to open a new issue for related bugs and link to relevant comments from this thread. |
Some more cleaning up! I haven't run this yet as a sanity check. I can do that in the am.