Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel communication #2628

Merged
merged 4 commits into from Mar 5, 2018
Merged

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Mar 5, 2018

  • improve messaging about kernel state
    • when it's the underlying process that has exited, denote it in the status
    • set the status when KILL_KERNEL_(SUCCESSFUL|FAILED)
  • 馃悰 the zeromq launch kernel epic was creating a brand new kernelRef instead of the one already specified

Copy link
Contributor

@theengineear theengineear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@theengineear theengineear merged commit a3be390 into nteract:master Mar 5, 2018
@rgbkrk rgbkrk deleted the kernel-communication branch March 5, 2018 19:04
@rgbkrk rgbkrk mentioned this pull request Mar 7, 2018
7 tasks
@lock
Copy link

lock bot commented May 4, 2018

Howdy! I'm 馃敁馃!

In order to keep information timely (based on the most recent release), we want all activity to be added to either new issues or open issues and PRs. In service to that goal, I, the lock bot close inactive closed issues when they haven't had activity in 120 days.

Feel free to open a new issue for related bugs and link to relevant comments from this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants