Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS for collapsed cell and remove outputExpanded #5085

Merged
merged 1 commit into from May 13, 2020

Conversation

captainsafia
Copy link
Member

Resolves #4448

As it turns out, we already had the toggle expanded property in the cell menu but we were missing the CSS for it. This is implemented now.

image

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #5085 into master will not change coverage.
The diff coverage is 71.42%.

@@           Coverage Diff           @@
##           master    #5085   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files         158      158           
  Lines        4584     4584           
  Branches      684      684           
=======================================
  Hits         3321     3321           
  Misses        978      978           
  Partials      285      285           

Copy link
Contributor

@CrystallineCat CrystallineCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left one comment in the code.

@@ -786,7 +786,6 @@ describe("toggleOutputExpansion", () => {
cells =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: change the outputExpanded in the name of the test:

test("changes outputExpanded set", () => ...)

@captainsafia captainsafia merged commit 47feb81 into master May 13, 2020
@badiku
Copy link

badiku commented May 28, 2020

packages/styles/themes/base.css
.nteract-cell-outputs {

overflow-y: scroll

doesn't this line you added force scroll bar to appear, even though there's only one line?

scrolly

I overrided this boring scroll bar like this :

from IPython.display import HTML
style = '''
    <style>
        div.nteract-cell-outputs {overflow-y: auto }
    </style>
    '''
HTML(style)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement UI support for collapsed property in notebook
3 participants