Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add “github” extra deps. to the “all” extra #715

Merged
merged 2 commits into from Nov 1, 2023

Conversation

musicinmybrain
Copy link
Contributor

What does this PR do?

Adds the dependencies for the github extra to the all extra. It looks like omitting these was an oversight rather than an intentional decision.

Fixes (no issue reported)

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #715 (f0bff45) into main (d5a986c) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #715   +/-   ##
=======================================
  Coverage   91.50%   91.50%           
=======================================
  Files          17       17           
  Lines        1625     1625           
=======================================
  Hits         1487     1487           
  Misses        138      138           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a986c...f0bff45. Read the comment docs.

@MSeal MSeal merged commit e304481 into nteract:main Nov 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants