Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Doesn't Get Data Accessors #23

Closed
mph006 opened this issue Sep 8, 2017 · 1 comment
Closed

Download Doesn't Get Data Accessors #23

mph006 opened this issue Sep 8, 2017 · 1 comment
Labels
bug 🐛 Known and possible bugs for triage

Comments

@mph006
Copy link
Contributor

mph006 commented Sep 8, 2017

The download feature in the XYFrame doesn't receive x/yAccessors.

Looks like they aren't being passed to xyDownloadMapping as expected
https://github.com/emeeks/semiotic/blob/master/src/components/downloadDataMapping.js#L10

Example:

<XYFrame
          {...sharedProps}
          className="line-xy"
          lineStyle={(d) => {return {stroke:d.color, strokeWidth: '2.5px'}}}
          lines={this.formatData(this.props.data)
            .filter((d)=>{return this.state.filterIndex.indexOf(d.id) === -1})}
          axes={axes}
          lineDataAccessor={(d)=> d.data}
          xAccessor={(d) => d.date}
          yAccessor={(d) => d.count}
          //lineRenderMode={"sketchy"}
          hoverAnnotation={true}
          download={true}
          //defined={(d) => d !== null}
          tooltipContent={(d) => {
            return this.fetchTooltipContent(d);
          }}
/>

screen shot 2017-09-08 at 3 49 28 pm

I suspect this is an issue in the OR frame as well.

Similarly, is there a way to pass a data accessor tonetworkNodeDownloadMapping / networkEdgeDownloadMapping?

@mph006 mph006 added the bug 🐛 Known and possible bugs for triage label Sep 8, 2017
@emeeks
Copy link
Member

emeeks commented Sep 14, 2017

Frames need to also be passed downloadFields which is an array of field ids to download the data for. As of 1.0.6 there is also support for download={points} in XYFrame to download the underlying points of lines and areas.

@emeeks emeeks closed this as completed Sep 14, 2017
alexeyraspopov pushed a commit that referenced this issue Dec 21, 2021
…s-4.5.3

Bump handlebars from 4.1.2 to 4.5.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Known and possible bugs for triage
Projects
None yet
Development

No branches or pull requests

2 participants