Cope with {connection_file} being a substring #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jupyter allows kernelspecs to contain arguments with {connection_file} as a
substring, e.g. `wslpath {connection_file}`. This commit uses
string.replace() to match that behaviour. Previously {connection_file} had to be an
argument on its own in argv.
|
@rwb27 I've published this package so that we can bring in the changes in the next release of the nteract desktop app. It will be released on February 24th. |
|
Brilliant! Thanks very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jupyter allows kernelspecs to contain arguments with
{connection_file}as asubstring, e.g.
`wslpath {connection_file}`. This commit usesstring.replace()to match that behaviour.Previously
{connection_file}had to be an argument on its own inargv. That's not a big deal, except if you're trying to do something niche, like start a kernel in Windows Subsystem Linux, that requires the filepath to be converted. This fixes #42.