[WIP] Lifecycle of a kernel #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the hard kill is trivial. Wouldn't it make more sense to implement the shutdown request since that is the most complex shutdown method? |
|
Also, could you add a simple unit test? |
|
Definitely. As I work on the build-your-own-repl guide I'll be coming back to this. |
|
Actually the shutdown request should be a helper method in the enchannel repo I think |
|
Related nteract/enchannel#9 |
|
I feel like you've already replaced what I've done here right @jdfreder? Should I close this? |
|
This is replaced by the other enchannel shutdown bits I think. I'll leave it up to Jon to revisit, I don't need this branch any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one helper method of many that are possible for killing.
Some will want a nice soft kill, sometimes you want a hard kill, sometimes you want to tell the kernel to politely shut down (using the messaging spec), etc. This one is a hard fast shut down.
Open to discussion.