Fix faulty prerun logic in notebook_loader #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
prerunfunctionality is faulty. It enters a kernel context, executes the specified cells and then exits the context. This means that the only thing modified is the output of the said cells of the notebook, and not the kernel context itself.I've moved the prerun logic in to the entry points of decorator pattern (
__call__) and context manager pattern (__enter__), which will then preserve the context of the prerun cells during the lifetime of the test.This means that sharing kernel context #17 across tests needs to be discussed further.