This repository has been archived by the owner on Aug 28, 2017. It is now read-only.
TF 2.0 #2
Merged
TF 2.0 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should probably be commonMarkTransform now...
| export default class MarkdownTransformer { | ||
| constructor() { | ||
| this.reader = new commonmark.Parser(); | ||
| this.writer = new commonmark.HtmlRenderer({ |
There was a problem hiding this comment.
I'm already missing the fact that these were classes before...
| let reader = new commonmark.Parser(); | ||
| let writer = new commonmark.HtmlRenderer({ | ||
| safe: true | ||
| }); |
There was a problem hiding this comment.
I'm tempted to wrap this in a closure so it's not creating the reader and writer everytime...
|
💥 now I can have closure |
|
Usage: > text = '```bash\nnpm install transformime-commonmark\n```\n';
> el = markdownTransform('text/markdown', text, document);
> el.innerHTML
'<pre><code class="language-bash">npm install transformime-commonmark\n</code></pre>\n' |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should probably be commonMarkTransform by now, but I digress.
I'll be adding some tests here as well.