prep release #1663
fafhrd91Annotations
40 warnings
|
non-binding `let` on a future:
ntex/src/server/worker.rs#L493
warning: non-binding `let` on a future
--> ntex/src/server/worker.rs:493:25
|
493 | / let _ = srv
494 | | .service
495 | | .call((Some(guard), ServerMessage::Connect(msg.io)));
| |_________________________________________________________________________________^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
= note: `#[warn(clippy::let_underscore_future)]` on by default
|
|
this `impl` can be derived:
ntex/src/http/payload.rs#L17
warning: this `impl` can be derived
--> ntex/src/http/payload.rs:17:1
|
17 | / impl Default for Payload {
18 | | fn default() -> Self {
19 | | Payload::None
20 | | }
21 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
10 | #[derive(Default)]
|
help: ...and mark the default variant
|
11 ~ #[default]
12 ~ None,
|
|
|
manual check for common ascii range:
ntex-router/src/quoter.rs#L53
warning: manual check for common ascii range
--> ntex-router/src/quoter.rs:53:8
|
53 | if (b'0'..=b'9').contains(&v) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `v.is_ascii_digit()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check
= note: `#[warn(clippy::manual_is_ascii_check)]` on by default
|
|
lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`:
ntex-http/src/value.rs#L2
warning: lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`
--> ntex-http/src/value.rs:2:5
|
2 | clippy::derive_hash_xor_eq,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::derived_hash_with_manual_eq`
|
= note: `#[warn(renamed_and_removed_lints)]` on by default
|
|
this `RefCell` reference is held across an `await` point:
ntex-glommio/src/io.rs#L514
warning: this `RefCell` reference is held across an `await` point
--> ntex-glommio/src/io.rs:514:41
|
514 | ... io.0.borrow()
| ^^^^^^^^^^^^^
|
= help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
--> ntex-glommio/src/io.rs:513:67
|
513 | ... let fut = Box::pin(async move {
| _____________________________________________________^
514 | | ... io.0.borrow()
515 | | ... .shutdown(std::net::Shutdown::Write)
516 | | ... .await
517 | | ... });
| |_______________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
|
|
this `RefCell` reference is held across an `await` point:
ntex-glommio/src/io.rs#L206
warning: this `RefCell` reference is held across an `await` point
--> ntex-glommio/src/io.rs:206:41
|
206 | ... io.0.borrow()
| ^^^^^^^^^^^^^
|
= help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
--> ntex-glommio/src/io.rs:205:67
|
205 | ... let fut = Box::pin(async move {
| _____________________________________________________^
206 | | ... io.0.borrow()
207 | | ... .shutdown(std::net::Shutdown::Write)
208 | | ... .await
209 | | ... });
| |_______________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
= note: `#[warn(clippy::await_holding_refcell_ref)]` on by default
|
|
this `impl` can be derived:
ntex-io/src/testing.rs#L91
warning: this `impl` can be derived
--> ntex-io/src/testing.rs:91:1
|
91 | / impl Default for IoTestState {
92 | | fn default() -> Self {
93 | | IoTestState::Ok
94 | | }
95 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
84 | #[derive(Default)]
|
help: ...and mark the default variant
|
85 ~ #[default]
86 ~ Ok,
|
|
|
this `else { if .. }` block can be collapsed:
ntex-io/src/buf.rs#L379
warning: this `else { if .. }` block can be collapsed
--> ntex-io/src/buf.rs:379:20
|
379 | } else {
| ____________________^
380 | | if let Some(mut buf) = self.curr.0.take() {
381 | | buf.extend_from_slice(&dst);
382 | | self.curr.0.set(Some(buf));
... |
386 | | }
387 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
379 ~ } else if let Some(mut buf) = self.curr.0.take() {
380 + buf.extend_from_slice(&dst);
381 + self.curr.0.set(Some(buf));
382 + self.io.memory_pool().release_read_buf(dst);
383 + } else {
384 + self.curr.0.set(Some(dst));
385 + }
|
|
|
very complex type used. Consider factoring parts into `type` definitions:
ntex-rt/src/lib.rs#L145
warning: very complex type used. Consider factoring parts into `type` definitions
--> ntex-rt/src/lib.rs:145:13
|
145 | Either<task::JoinHandle<T>, Pin<Box<dyn Future<Output = Result<T, Canceled>>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
this let-binding has unit value:
ntex-rt/src/lib.rs#L66
warning: this let-binding has unit value
--> ntex-rt/src/lib.rs:66:13
|
66 | let _ = fut.await;
| ^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `fut.await;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
non-binding `let` on a future:
ntex/src/server/worker.rs#L493
warning: non-binding `let` on a future
--> ntex/src/server/worker.rs:493:25
|
493 | / let _ = srv
494 | | .service
495 | | .call((Some(guard), ServerMessage::Connect(msg.io)));
| |_________________________________________________________________________________^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
= note: `#[warn(clippy::let_underscore_future)]` on by default
|
|
this `impl` can be derived:
ntex/src/http/payload.rs#L17
warning: this `impl` can be derived
--> ntex/src/http/payload.rs:17:1
|
17 | / impl Default for Payload {
18 | | fn default() -> Self {
19 | | Payload::None
20 | | }
21 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
10 | #[derive(Default)]
|
help: ...and mark the default variant
|
11 ~ #[default]
12 ~ None,
|
|
|
manual check for common ascii range:
ntex-router/src/quoter.rs#L53
warning: manual check for common ascii range
--> ntex-router/src/quoter.rs:53:8
|
53 | if (b'0'..=b'9').contains(&v) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `v.is_ascii_digit()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check
= note: `#[warn(clippy::manual_is_ascii_check)]` on by default
|
|
this `RefCell` reference is held across an `await` point:
ntex-glommio/src/io.rs#L514
warning: this `RefCell` reference is held across an `await` point
--> ntex-glommio/src/io.rs:514:41
|
514 | ... io.0.borrow()
| ^^^^^^^^^^^^^
|
= help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
--> ntex-glommio/src/io.rs:513:67
|
513 | ... let fut = Box::pin(async move {
| _____________________________________________________^
514 | | ... io.0.borrow()
515 | | ... .shutdown(std::net::Shutdown::Write)
516 | | ... .await
517 | | ... });
| |_______________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
|
|
this `RefCell` reference is held across an `await` point:
ntex-glommio/src/io.rs#L206
warning: this `RefCell` reference is held across an `await` point
--> ntex-glommio/src/io.rs:206:41
|
206 | ... io.0.borrow()
| ^^^^^^^^^^^^^
|
= help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
--> ntex-glommio/src/io.rs:205:67
|
205 | ... let fut = Box::pin(async move {
| _____________________________________________________^
206 | | ... io.0.borrow()
207 | | ... .shutdown(std::net::Shutdown::Write)
208 | | ... .await
209 | | ... });
| |_______________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
= note: `#[warn(clippy::await_holding_refcell_ref)]` on by default
|
|
lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`:
ntex-http/src/value.rs#L2
warning: lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`
--> ntex-http/src/value.rs:2:5
|
2 | clippy::derive_hash_xor_eq,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::derived_hash_with_manual_eq`
|
= note: `#[warn(renamed_and_removed_lints)]` on by default
|
|
this `impl` can be derived:
ntex-io/src/testing.rs#L91
warning: this `impl` can be derived
--> ntex-io/src/testing.rs:91:1
|
91 | / impl Default for IoTestState {
92 | | fn default() -> Self {
93 | | IoTestState::Ok
94 | | }
95 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
84 | #[derive(Default)]
|
help: ...and mark the default variant
|
85 ~ #[default]
86 ~ Ok,
|
|
|
this `else { if .. }` block can be collapsed:
ntex-io/src/buf.rs#L379
warning: this `else { if .. }` block can be collapsed
--> ntex-io/src/buf.rs:379:20
|
379 | } else {
| ____________________^
380 | | if let Some(mut buf) = self.curr.0.take() {
381 | | buf.extend_from_slice(&dst);
382 | | self.curr.0.set(Some(buf));
... |
386 | | }
387 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
379 ~ } else if let Some(mut buf) = self.curr.0.take() {
380 + buf.extend_from_slice(&dst);
381 + self.curr.0.set(Some(buf));
382 + self.io.memory_pool().release_read_buf(dst);
383 + } else {
384 + self.curr.0.set(Some(dst));
385 + }
|
|
|
very complex type used. Consider factoring parts into `type` definitions:
ntex-rt/src/lib.rs#L145
warning: very complex type used. Consider factoring parts into `type` definitions
--> ntex-rt/src/lib.rs:145:13
|
145 | Either<task::JoinHandle<T>, Pin<Box<dyn Future<Output = Result<T, Canceled>>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
this let-binding has unit value:
ntex-rt/src/lib.rs#L66
warning: this let-binding has unit value
--> ntex-rt/src/lib.rs:66:13
|
66 | let _ = fut.await;
| ^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `fut.await;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
nightly - x86_64-apple-darwin
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/cache@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
|
|
nightly - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
nightly - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
nightly - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
nightly - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
nightly - x86_64-apple-darwin:
ntex-io/src/testing.rs#L476
variable does not need to be mutable
|
|
nightly - x86_64-apple-darwin
`ntex-io` (lib) generated 1 warning (run `cargo fix --lib -p ntex-io` to apply 1 suggestion)
|
|
nightly - x86_64-apple-darwin:
ntex-tokio/src/io.rs#L131
variable does not need to be mutable
|
|
nightly - x86_64-apple-darwin:
ntex-tokio/src/io.rs#L526
variable does not need to be mutable
|
|
nightly - x86_64-apple-darwin
`ntex-tokio` (lib) generated 2 warnings (run `cargo fix --lib -p ntex-tokio` to apply 2 suggestions)
|
|
nightly - x86_64-apple-darwin:
ntex-async-std/src/io.rs#L127
variable does not need to be mutable
|
|
nightly - x86_64-apple-darwin:
ntex-async-std/src/io.rs#L435
variable does not need to be mutable
|
|
nightly - x86_64-apple-darwin
`ntex-async-std` (lib) generated 2 warnings (run `cargo fix --lib -p ntex-async-std` to apply 2 suggestions)
|
|
nightly - x86_64-apple-darwin
`ntex-async-std` (lib test) generated 2 warnings (2 duplicates)
|
|
nightly - x86_64-apple-darwin
`ntex-io` (lib test) generated 1 warning (1 duplicate)
|
|
stable - x86_64-apple-darwin
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/cache@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
|
|
stable - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
stable - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
stable - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
stable - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|