Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The insert method for Extensions does not return existed value #345

Closed
photino opened this issue Apr 23, 2024 · 1 comment
Closed

The insert method for Extensions does not return existed value #345

photino opened this issue Apr 23, 2024 · 1 comment

Comments

@photino
Copy link

photino commented Apr 23, 2024

The docs for insert says that

If a extension of this type already existed, it will be returned.

But it does not. The function signature should be

pub fn insert<T>(&mut self, val: T) -> Option<T>
where
    T: 'static,
@fafhrd91
Copy link
Member

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants