Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rustls version to 0.21 #201

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Upgrade rustls version to 0.21 #201

merged 4 commits into from
Jun 15, 2023

Conversation

clia
Copy link
Contributor

@clia clia commented May 7, 2023

Since rustls version 0.21.1 has a fix to ConnectionCommon::complete_io, I wish to have a try to see if it can resolve this #190.

@fafhrd91
Copy link
Collaborator

fafhrd91 commented May 7, 2023

you should really try openssl, i use it in prod and sure about implementation. i am not so sure about rustls

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (adb74ed) 90.77% compared to head (e9d5c05) 90.76%.

❗ Current head e9d5c05 differs from pull request most recent head 2a80c8b. Consider uploading reports for the commit 2a80c8b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   90.77%   90.76%   -0.01%     
==========================================
  Files         188      188              
  Lines       30538    30532       -6     
==========================================
- Hits        27720    27713       -7     
- Misses       2818     2819       +1     
Impacted Files Coverage Δ
ntex-tls/src/rustls/server.rs 82.01% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fafhrd91
Copy link
Collaborator

could you remove changes to Cargo.toml for ntex and ntex-connect

@fafhrd91 fafhrd91 changed the base branch from master to ntex-0.7 June 15, 2023 05:43
@fafhrd91 fafhrd91 merged commit 627b08e into ntex-rs:ntex-0.7 Jun 15, 2023
@fafhrd91
Copy link
Collaborator

thanks!

fafhrd91 pushed a commit that referenced this pull request Jun 15, 2023
* Upgrade rustls version to 0.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants