Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronized buffer #216

Merged
merged 8 commits into from
Jun 26, 2023
Merged

Synchronized buffer #216

merged 8 commits into from
Jun 26, 2023

Conversation

wpbrown
Copy link
Contributor

@wpbrown wpbrown commented Jun 24, 2023

  • added a new function to servicecall to allow only advancing to the service call and then returning the service response future
  • buffer can maintain order/backpressure by implementing strict readiness and synchronous calling
  • buffer can flush in order or cancel pending buffered futures on shutdown

@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Patch coverage: 63.04% and project coverage change: -0.14 ⚠️

Comparison is base (4380b3a) 90.99% compared to head (218cedd) 90.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   90.99%   90.86%   -0.14%     
==========================================
  Files         189      189              
  Lines       30829    30944     +115     
==========================================
+ Hits        28052    28116      +64     
- Misses       2777     2828      +51     
Impacted Files Coverage Δ
ntex-service/src/lib.rs 79.62% <ø> (ø)
ntex-util/src/services/buffer.rs 78.26% <56.43%> (-20.97%) ⬇️
ntex-service/src/ctx.rs 92.18% <81.08%> (-2.66%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

ntex-util/src/services/buffer.rs Outdated Show resolved Hide resolved
ntex-util/src/services/buffer.rs Outdated Show resolved Hide resolved
rename bufferserviceerrror
consistent spelling of cancel
unmerge usings
impl std error
@wpbrown wpbrown marked this pull request as ready for review June 25, 2023 14:45
@fafhrd91 fafhrd91 merged commit eea5b3b into ntex-rs:master Jun 26, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants