Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github-actions): use rust toolchain arm64 version for macos 14 #355

Conversation

msga-mmm
Copy link
Contributor

@msga-mmm msga-mmm commented May 5, 2024

The tests on MacOS runner were failing due to an error in the linking step:

= note: ld: warning: ignoring file '/opt/homebrew/Cellar/openssl@3/3.3.0/lib/libssl.3.dylib': found architecture 'arm64', required architecture 'x86_64'

The tests seem to have started to fail recently which might be related to the update of macos 12 to 14 when using the tag macos-latest in the github runner:

One month ago:
image

Recently:
image

It could be fixed by pinning the macos version to 12 or using the arm64 version toolchain.

In this pull request I updated the macos tests to use the arm64 version in case this results useful.

@msga-mmm msga-mmm marked this pull request as ready for review May 5, 2024 04:24
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.70%. Comparing base (33490cd) to head (60d08f9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   90.64%   90.70%   +0.06%     
==========================================
  Files         197      197              
  Lines       31653    31664      +11     
==========================================
+ Hits        28691    28720      +29     
+ Misses       2962     2944      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fafhrd91 fafhrd91 merged commit 1b3a530 into ntex-rs:master May 5, 2024
12 checks passed
@fafhrd91
Copy link
Collaborator

fafhrd91 commented May 5, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants