Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async fn for Service::ready() and Service::shutdown() #364

Merged
merged 1 commit into from
May 28, 2024

Conversation

fafhrd91
Copy link
Member

No description provided.

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 90.93%. Comparing base (dec6ab0) to head (b5afef6).
Report is 2 commits behind head on master.

Files Patch % Lines
ntex/src/http/h1/service.rs 46.15% 7 Missing ⚠️
ntex/src/http/service.rs 69.23% 4 Missing ⚠️
ntex/src/http/h2/service.rs 50.00% 2 Missing ⚠️
ntex/src/ws/client.rs 66.66% 2 Missing ⚠️
ntex/src/http/client/connector.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   90.40%   90.93%   +0.53%     
==========================================
  Files         198      198              
  Lines       31918    31872      -46     
==========================================
+ Hits        28854    28984     +130     
+ Misses       3064     2888     -176     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fafhrd91 fafhrd91 merged commit 3b49828 into master May 28, 2024
21 of 22 checks passed
@fafhrd91 fafhrd91 deleted the async-ready-ntex branch May 28, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant