Skip to content

Merge pull request #211 from ntex-rs/beta0-release #1721

Merge pull request #211 from ntex-rs/beta0-release

Merge pull request #211 from ntex-rs/beta0-release #1721

GitHub Actions / clippy succeeded Jun 16, 2023 in 0s

clippy

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.70.0 (90c541806 2023-05-31)
  • cargo 1.70.0 (ec8a8a0ca 2023-04-25)
  • clippy 0.1.70 (90c5418 2023-05-31)

Annotations

Check warning on line 514 in ntex-glommio/src/io.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `RefCell` reference is held across an `await` point

warning: this `RefCell` reference is held across an `await` point
   --> ntex-glommio/src/io.rs:514:41
    |
514 | ...                   io.0.borrow()
    |                       ^^^^^^^^^^^^^
    |
    = help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
   --> ntex-glommio/src/io.rs:513:67
    |
513 |   ...                   let fut = Box::pin(async move {
    |  _____________________________________________________^
514 | | ...                       io.0.borrow()
515 | | ...                           .shutdown(std::net::Shutdown::Write)
516 | | ...                           .await
517 | | ...                   });
    | |_______________________^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref

Check warning on line 206 in ntex-glommio/src/io.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `RefCell` reference is held across an `await` point

warning: this `RefCell` reference is held across an `await` point
   --> ntex-glommio/src/io.rs:206:41
    |
206 | ...                   io.0.borrow()
    |                       ^^^^^^^^^^^^^
    |
    = help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
   --> ntex-glommio/src/io.rs:205:67
    |
205 |   ...                   let fut = Box::pin(async move {
    |  _____________________________________________________^
206 | | ...                       io.0.borrow()
207 | | ...                           .shutdown(std::net::Shutdown::Write)
208 | | ...                           .await
209 | | ...                   });
    | |_______________________^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
    = note: `#[warn(clippy::await_holding_refcell_ref)]` on by default

Check warning on line 145 in ntex-rt/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
   --> ntex-rt/src/lib.rs:145:13
    |
145 |             Either<task::JoinHandle<T>, Pin<Box<dyn Future<Output = Result<T, Canceled>>>>>,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
    = note: `#[warn(clippy::type_complexity)]` on by default