upnpsoap: fix uninitialized read with emtpy filter

ntfreak · Apr 7, 2014 · e3792ad · e3792ad
1 parent 301b045
commit e3792ad
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/upnpsoap.c b/upnpsoap.c
@@ -351,13 +351,13 @@ set_filter_flags(char *filter, struct upnphttp *h)
 	int samsung = client_types[h->req_client].flags & FLAG_SAMSUNG;
 
 	if( !filter || (strlen(filter) <= 1) ) {
-		if (strcmp(filter, "*") == 0 && samsung) {
-			return 0xFFFFFFFF;  /* We want FILTER_SEC_DCM_INFO */
-		} else {
-			/* Not the full 32 bits.  Skip vendor-specific stuff by default. */
-			return 0xFFFFFF;
-		}
+		/* Not the full 32 bits.  Skip vendor-specific stuff by default. */
+		flags = 0xFFFFFF;
+		if (samsung)
+			flags |= FILTER_SEC_CAPTION_INFO_EX | FILTER_SEC_DCM_INFO;
 	}
+	if (flags)
+		return flags;
 
 	if( samsung )
 		flags |= FILTER_DLNA_NAMESPACE;