Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes #15

Merged
merged 6 commits into from
Jul 13, 2021
Merged

Routes #15

merged 6 commits into from
Jul 13, 2021

Conversation

jongbonga
Copy link
Contributor

Create empty pages/views

@jongbonga jongbonga added the M: web-client Module: Web client app (Angular) label Jul 6, 2021
@jongbonga jongbonga self-assigned this Jul 6, 2021
@netlify
Copy link

netlify bot commented Jul 6, 2021

✔️ Deploy Preview for nautilus-wallet ready!

🔨 Explore the source changes: 6cfee40

🔍 Inspect the deploy log: https://app.netlify.com/sites/nautilus-wallet/deploys/60ecc24cb5ea9a000868753c

😎 Browse the preview: https://deploy-preview-15--nautilus-wallet.netlify.app

jongbonga and others added 3 commits July 12, 2021 15:15
Co-authored-by: Pi Delport <pi@registree.io>
Co-authored-by: Pi Delport <pi@registree.io>
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #15 (6cfee40) into main (74fec6e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         9    +5     
  Lines            8        24   +16     
=========================================
+ Hits             8        24   +16     
Impacted Files Coverage Δ
web-client/src/app/views/home/home.page.ts 100.00% <100.00%> (ø)
web-client/src/app/views/landing/landing.page.ts 100.00% <100.00%> (ø)
web-client/src/app/views/login/login.page.ts 100.00% <100.00%> (ø)
web-client/src/app/views/register/register.page.ts 100.00% <100.00%> (ø)
...client/src/app/views/send-funds/send-funds.page.ts 100.00% <100.00%> (ø)
web-client/src/app/views/wallet/wallet.page.ts 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26886f9...6cfee40. Read the comment docs.

Copy link
Collaborator

@PiDelport PiDelport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jongbonga had a session to update and rebase this, and I pulled in the test fixes from #14 and added stub stories for the new views.

@jongbonga: Can you give this a final look? Maybe we can use this PR to get Abby on board for reviewing the story changes on Chromatic?

Nautilus Wallet automation moved this from Review in progress to Reviewer approved Jul 12, 2021
Copy link
Collaborator

@longtomjr longtomjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jongbonga jongbonga merged commit 57a24d4 into main Jul 13, 2021
Nautilus Wallet automation moved this from Reviewer approved to Done Jul 13, 2021
@jongbonga jongbonga deleted the routes branch July 13, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M: web-client Module: Web client app (Angular)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants