-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: menu list as template #163
Conversation
@dword-design Thank you for your contribution! But could you make the PR to |
@kikuomax done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM⚡Please wait for @kikuomax to review this code before pulling this PR into dev.
(I just realized this PR is still a draft 😅)
@dword-design @wesdevpro Please give me some time to see if there might be potential drawbacks. |
@dword-design @wesdevpro I will look into this PR after I finish #159. |
@dword-design Did you mean functional components wouldn't work in Nuxt production in general? |
@kikuomax Ok I debugged myself into this and I think the problem is that we use |
@dword-design Great insight! Now, I remember I faced the exact problem fixed at d44e6d2 that is not merged to |
While the problem should have already been solved, I think an ordinary component is more intuitive and this PR is still relevant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I turned the menu list into a template, first for consistency and the function implementation didn't work in Nuxt production.